[DAS 358] - Added optional parameters to upload function #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds optional metadata parameters to upload functions to support additional HTTP headers like content type, disposition, encoding, cache control, and user-defined metadata during file uploads.
- Added 5 new optional metadata parameters to the upload function signature
- Updated method calls to pass through the new metadata parameters
- Modified both deprecated and current upload method interfaces
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| ossFileTransfer.ts | Extended upload method signature with metadata parameters and updated API call |
| ossClient.ts | Updated uploadObjectAsync and uploadObject methods to accept and pass metadata parameters |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
srivastavarahull
force-pushed
the
DAS-358-add-xAdsMeta-propertites-to-upload
branch
from
e3dfc54 to
20e7b4c
Compare
nishchhaldagar
approved these changes
Nov 10, 2025
srivastavarahull
force-pushed
the
DAS-358-add-xAdsMeta-propertites-to-upload
branch
from
5c2d244 to
db004fd
Compare
nishchhaldagar
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.